release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

Prerelease option

Open ChipWolf opened this issue 4 years ago • 6 comments
trafficstars

Surface the prerelease parameter from release-please

ChipWolf avatar Oct 26 '21 19:10 ChipWolf

This is now available upstream https://github.com/googleapis/release-please/pull/1200

ChipWolf avatar Jan 12 '22 14:01 ChipWolf

Workaround is to use the prerelease option in the manifest releaser.

ChipWolf avatar Jan 30 '22 13:01 ChipWolf

The manifest releaser doesn't seem to work correctly. E.g., I had changes in 3 packages and It created 3 releases out of which only the first one was created as prerelease. My config

{
  "prerelease": true,
  "bootstrap-sha": "6f0472d2059ddbd8db6d839f2ed586a4ea790a3f",
  "packages": {
    "packages/foo": {},
    "packages/bar": {},
    "packages/johngalt": {}
  }
}

mrchief avatar Feb 24 '22 17:02 mrchief

On second look, the docs mention

those as "Prerelease" releases that have pre-major or prerelease versions.

so it's working as advertised but also is misleading of sorts. No way to create prereleases for post major versions.

mrchief avatar Feb 24 '22 17:02 mrchief

On second look, the docs mention

those as "Prerelease" releases that have pre-major or prerelease versions.

so it's working as advertised but also is misleading of sorts. No way to create prereleases for post major versions.

Probably worth raising that issue upstream

ChipWolf avatar Feb 24 '22 19:02 ChipWolf

@ChipWolf if there's a bug with the prerelease behavior, I think we should open an issue on the release-please repository.

It sounds like along with this, we just want to add an additional configuration option to the action?

bcoe avatar Mar 20 '22 14:03 bcoe