release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

prepend changelog instead of overwrite for legacy project

Open gengjiawen opened this issue 5 years ago • 3 comments

Same from https://github.com/gengjiawen/node-gyp/pull/2/files.

The history changelog is very important. Maybe just prepend new in file header.

gengjiawen avatar Feb 16 '21 03:02 gengjiawen

I doubt it will be able to append the current changelog as it's not following the same format. (You might be able to regenerate everything from the first tag though)

The logic for generating changelog is actually managed by release-please npm lib. Ref: https://github.com/googleapis/release-please/blob/master/package.json#L65-L66

pragmaticivan avatar Feb 16 '21 04:02 pragmaticivan

we attempt to detect prior releases and keep the prior CHANGELOG entry, we just don't understand the format:

v7.1.2 2020-10-17

I could imagine adding support for this, for the benefit of node-gyp.

bcoe avatar Feb 17 '21 01:02 bcoe

@gengjiawen another option would be manually changing the CHANGELOG before merging the first time, at which point future releases will find the new header format correctly.

bcoe avatar Feb 17 '21 01:02 bcoe