release-please-action icon indicating copy to clipboard operation
release-please-action copied to clipboard

[Feature request] append artifact to release.

Open gengjiawen opened this issue 3 years ago • 4 comments

I really enjoy using release-please (thanks for this project). I introduce to my electron project, which need artifact on release

My previous release like this, include binary for auto-updates. image

But with release please, I can only get this (this will also break auto-updater for electron).

image

It would be much wonderful to use artifacts in this case.

gengjiawen avatar Jan 07 '21 02:01 gengjiawen

I really enjoy using release-please (thanks for this project)

Thank you 👏

I introduce to my electron project, which need artifact on release

I was talking to my colleague @JustinBeckwith today, about how he'd like a version of release please that handles advanced workflows (in his case, like publishing to npm).

My thinking, is that it would be good to add guides in docs/ that demonstrate complex workflows:

  • docs/npm.md: how you wire up a GitHub action, with release-please, to publish to npm.
  • docs/electron.md: how you wire up a GitHub action, with release-please, to publish artifacts to the release.

Question: when you're creating an electron application, how are the artifacts created, is it a step that happens, e.g., npm run build?

bcoe avatar Jan 07 '21 04:01 bcoe

FWIW, this is something semantic-release-github supports. I needed this in linkinator to attach release binaries generated by vercel/pgk as part of the release.

JustinBeckwith avatar Jan 07 '21 05:01 JustinBeckwith

My thinking, is that it would be good to add guides in docs/ that demonstrate complex workflows:

This looks very good to me.

Question: when you're creating an electron application, how are the artifacts created, is it a step that happens, e.g., npm run build?

yarn electron-build

gengjiawen avatar Jan 08 '21 01:01 gengjiawen

Hi, any update or work around on this issue?

Oyabi avatar Aug 14 '21 02:08 Oyabi

This is also something I need. Right now it breaks my building of artifacts on https://github.com/slurdge/goeland/, even though there is a tag created.

slurdge avatar Nov 15 '22 11:11 slurdge