deploy-cloudrun icon indicating copy to clipboard operation
deploy-cloudrun copied to clipboard
verified publisher icon google-github-actions

feat(run): adds Worker Pool support to deploy-cloudrun action

Open matbrito opened this issue 4 months ago • 6 comments

Add support do worker pool. Some considerations of this PR are placed below:

  • Worker pool only exists in alpha and beta gcloud components.
  • There is no region flag when using replace command (metadata) in worker pool. Official documentation

matbrito avatar Sep 08 '25 15:09 matbrito

Thanks for the PR. I'm supportive of adding worker pool (assuming it has been added on the same model as jobs)

We are looking for someone at Google to review the PR

steren avatar Oct 09 '25 21:10 steren

@matbrito Thanks for your initial work on updating this GitHub Action. I haven't finished reviewing, but I wanted to give you some initial feedback. Overall, the approach looks consistent to how jobs/services work.

Hi @iennae, thanks for your initial review, i've just made some code changes related to the comments you left. I'm totally open to new comments and suggestions

matbrito avatar Oct 10 '25 20:10 matbrito

@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here!

iennae avatar Oct 15 '25 06:10 iennae

A friendly bump just in case it fell through the cracks - supporting this would be awesome 🙏

bai avatar Oct 24 '25 08:10 bai

@matbrito thanks, I'll try to revisit by Friday for a last review. Appreciate your patience here!

Hi @iennae did you have time to take a look? I've also fixed some lint issues, is it possible to rerun all workflows?

matbrito avatar Nov 01 '25 14:11 matbrito

please? 😂

dorukgezici avatar Nov 11 '25 14:11 dorukgezici