deploy-cloudrun
deploy-cloudrun copied to clipboard
Add CloudSQL flag
--add-cloudsql-instances
as documented in https://cloud.google.com/sql/docs/mysql/connect-run#node.js
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
Do you plan at some point to merge this ?
Thank you for your patience. Can you resolve the merge conflict?
So this should be handled in with the cli/console at the moment? Waiting as well.
Any update on this?
Any update when this is coming in google APIS SDK?
@bkniffler @averikitsch hello. I tried to resolve the conflict in this pull request, but the configuration has changed, such as src/deploy-cloudrun.ts being deleted, so the conflict could not be resolved. So I recreated a new pull request. https://github.com/google-github-actions/deploy-cloudrun/pull/389
To anyone that can't wait for this PR to be merged, you can use the flags
input to use the arguments that are currently not supported
flags:
description: |-
Space separated list of other Cloud Run flags, examples can be found:
https://cloud.google.com/sdk/gcloud/reference/run/deploy#FLAGS. Ex
[email protected] --concurrency=10
required: false
Sample step would be for customizing the CPU and Memory during deployment
- name: Deploy to Cloud Run
id: deploy
uses: google-github-actions/deploy-cloudrun@v0
with:
service: ${{ env.SERVICE }}
region: ${{ env.REGION }}
image: ${{ env.REGISTRY }}/${{ env.PROJECT_ID }}/${{ env.GHUB_REPO_NAME }}/${{ env.SERVICE }}:${{ github.sha }}
project_id: ${{ env.PROJECT_ID }}
flags: --cpu 1000m --memory 384Mi
Cheers!
Closed as duplicate of #389