deploy-cloudrun icon indicating copy to clipboard operation
deploy-cloudrun copied to clipboard

Add CloudSQL flag

Open bkniffler opened this issue 3 years ago • 7 comments

--add-cloudsql-instances as documented in https://cloud.google.com/sql/docs/mysql/connect-run#node.js

bkniffler avatar Nov 03 '21 21:11 bkniffler

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 03 '21 21:11 google-cla[bot]

@googlebot I signed it!

bkniffler avatar Nov 03 '21 21:11 bkniffler

Do you plan at some point to merge this ?

JeandeCampredon avatar May 12 '22 12:05 JeandeCampredon

Thank you for your patience. Can you resolve the merge conflict?

averikitsch avatar Jul 29 '22 19:07 averikitsch

So this should be handled in with the cli/console at the moment? Waiting as well.

nadavzipo avatar Aug 22 '22 12:08 nadavzipo

Any update on this?

faizeev47 avatar Aug 26 '22 22:08 faizeev47

Any update when this is coming in google APIS SDK?

FaizeKhan12 avatar Aug 29 '22 09:08 FaizeKhan12

@bkniffler @averikitsch hello. I tried to resolve the conflict in this pull request, but the configuration has changed, such as src/deploy-cloudrun.ts being deleted, so the conflict could not be resolved. So I recreated a new pull request. https://github.com/google-github-actions/deploy-cloudrun/pull/389

178inaba avatar Oct 10 '22 16:10 178inaba

To anyone that can't wait for this PR to be merged, you can use the flags input to use the arguments that are currently not supported

flags:
    description: |-
      Space separated list of other Cloud Run flags, examples can be found:
      https://cloud.google.com/sdk/gcloud/reference/run/deploy#FLAGS. Ex
      [email protected] --concurrency=10
    required: false

Sample step would be for customizing the CPU and Memory during deployment

  - name: Deploy to Cloud Run
    id: deploy
    uses: google-github-actions/deploy-cloudrun@v0
    with:
      service: ${{ env.SERVICE }}
      region: ${{ env.REGION }}
      image: ${{ env.REGISTRY }}/${{ env.PROJECT_ID }}/${{ env.GHUB_REPO_NAME }}/${{ env.SERVICE }}:${{ github.sha }}
      project_id: ${{ env.PROJECT_ID }}
      flags: --cpu 1000m --memory 384Mi

Cheers!

vincejv avatar Oct 16 '22 09:10 vincejv

Closed as duplicate of #389

verbanicm avatar Nov 03 '22 13:11 verbanicm