generative-ai-python icon indicating copy to clipboard operation
generative-ai-python copied to clipboard

Add `python3.8` support

Open Danipulok opened this issue 1 year ago • 1 comments

Description of the change

Add python 3.8 support. Add tests for python 3.8. All the tests are passing.

Motivation

Some productions (for example, our team) still uses python3.8.

Type of change

Feature request

Checklist

  • [x] I have performed a self-review of my code.
  • [x] I have added detailed comments to my code where applicable.
  • [x] I have verified that my change does not break existing code.
  • [x] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • [x] I am familiar with the Google Style Guide for the language I have coded in.
  • [x] I have read through the Contributing Guide and signed the Contributor License Agreement.

Danipulok avatar Dec 01 '23 08:12 Danipulok

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 01 '23 08:12 google-cla[bot]

Thanks! but I don't think we're doing this.

Sorry!

MarkDaoust avatar May 17 '24 21:05 MarkDaoust