google-gemini
Support modifyOtherKeys to support shift+enter in tmux
What would you like to be added?
We should extend terminalCapablityManager to detect whether the terminal supports modifyOtherKeys For terminals that do we should use it to detect shift+enter.
While tmux lacks support for the kitty protocol it supports the slightly older modifyOtherKeys protocol.
Why is this needed?
tmux users are unable to press shift+enter today. We are also missing out on differentiating ctrl-I and tab and similar cases.
Additional context
No response
@ishaanxgupta Sure. I've added you as assigned. Try to get me a PR by EOD tomorrow (PST) otherwise I won't be able to contain the urge to try it myself 😄
Fyi as soon as https://github.com/google-gemini/gemini-cli/pull/15132 lands you will want to sync to those changes as that pr refactors how we detect various terminal capabilities such as support for modifyOtherKeys. One thing we'll want to watch out for is that terminals that support the kitty protocol should continue to use it rather than the modifyOtherKeys functionality.
Ok. https://github.com/google-gemini/gemini-cli/pull/15132 is merged. I'm actually on vacation for two weeks starting Monday but I will check in on this. Please ping me on this thread when you have a PR ready to review. Thanks!