Harden IDE lookup and WebFetch private-IP handling

[dev-shinyu]

Summary

Harden IDE CLI lookup and WebFetch private-IP checks to improve safety.

Changes

• Use spawn-based command lookup (no shell interpretation) for IDE installers.
• Rework private-IP detection (DNS + IPv4/IPv6 ranges) and make WebFetch fall back on internal URLs.
• Add/update unit tests:
  • src/utils/fetch.test.ts
  • src/ide/ide-installer.test.ts
  • src/tools/web-fetch.test.ts
• Run Vitest with the threads pool and log uncaught/unhandled errors in test workers.

Tests

• npm run test --workspace @google/gemini-cli-core -- src/utils/fetch.test.ts src/ide/ide-installer.test.ts src/tools/web-fetch.test.ts
• Result: pass (3 files, 53 tests). JUnit + coverage artifacts under packages/core.

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist[bot]]

Summary of Changes

Hello @dev-shinyu, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the security posture of the application by implementing safer command execution for IDE integrations and introducing a more robust private IP detection system for web fetching. These changes aim to mitigate risks associated with arbitrary command execution and prevent unintended access to internal network resources, ensuring a more secure and reliable operation.

Highlights

• Enhanced Security for IDE CLI Lookup: The IDE CLI lookup mechanism has been hardened by switching from execSync to spawnSync for command execution, explicitly disabling shell interpretation to prevent potential command injection vulnerabilities.
• Improved Private IP Detection for WebFetch: The isPrivateIp function has been completely reworked to include comprehensive detection of private IPv4 and IPv6 addresses, leveraging DNS resolution and standard private IP ranges. WebFetch operations will now fall back to internal URLs if a private IP is detected.
• Updated Test Infrastructure: New unit tests have been added for the enhanced private IP detection logic, and existing tests for IDE installers and WebFetch have been updated to reflect the changes. Vitest is now configured to run tests in a threads pool and log uncaught exceptions/unhandled rejections for better debugging.
• Dependency Management Updates: The package-lock.json file has been updated, primarily by adding or removing the peer: true flag for several dependencies, indicating adjustments in how peer dependencies are managed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.