Add an integration test for ACP

[gsabran]

Summary

Add an integration test to ensure ACP is not broken. This test validate that the initial handshake is successful.

Details

This relates to a recent regression: https://github.com/google-gemini/gemini-cli/pull/14159 https://github.com/google-gemini/gemini-cli/issues/14137 https://github.com/google-gemini/gemini-cli/pull/13795

The regression would have been prevented if the test had existed.

Related Issues

See above

How to Validate

This is a new test, it'll be validated in CI

Pre-Merge Checklist

• [ ] Updated relevant documentation and README (if needed)
• [x] Added/updated tests (if needed)
• [ ] Noted breaking changes (if any)
• [ ] Validated on required platforms/methods:
  • [ ] MacOS
    • [ ] npm run
    • [ ] npx
    • [ ] Docker
    • [ ] Podman
    • [ ] Seatbelt
  • [ ] Windows
    • [ ] npm run
    • [ ] npx
    • [ ] Docker
  • [ ] Linux
    • [ ] npm run
    • [ ] npx
    • [ ] Docker

[google-cla[bot]]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist[bot]]

Summary of Changes

Hello @gsabran, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial integration test for the Application Control Protocol (ACP), focusing on the successful execution of its initial JSON-RPC handshake. The primary goal is to enhance the robustness of the system by proactively catching potential issues that could lead to regressions in ACP functionality. Additionally, a minor adjustment was made to the test infrastructure to ensure accurate output handling during ACP-specific test runs.

Highlights

• New Integration Test for ACP: A new integration test has been added specifically for the Application Control Protocol (ACP) to validate its JSON-RPC handshake mechanism. This test ensures that the initialize method returns a valid JSON-RPC 2.0 response.
• Regression Prevention: This new test aims to prevent future regressions related to ACP, similar to a recent issue where the ACP protocol was inadvertently broken.
• Test Helper Update: The TestRig utility in test-helper.ts has been updated to correctly handle output when running in --experimental-acp mode. It now prevents stderr content from being included in the test result, as ACP communication is expected to be pure JSON-RPC.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.