Remove foreground for themes other than shades of purple and holiday.

[jacob314]

Summary

I accidentally undid this change. Added it back.

Details

Reproduce by toggling between themes. Notice that the foreground color remains unchanged.

[gemini-code-assist[bot]]

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the theme definitions by removing explicit 'Foreground' color settings from a wide array of themes. The primary purpose of this change is to simplify theme maintenance and ensure consistency by allowing foreground colors to be determined by a default or inherited mechanism, rather than being hardcoded in each theme configuration. This reduces redundancy and makes the theme system more flexible.

Highlights

• Theme Customization: The 'Foreground' color property has been removed from numerous theme definitions, including 'ansi-light', 'ansi', 'atom-one-dark', 'ayu-light', 'ayu', 'dracula', 'github-dark', 'github-light', 'googlecode', 'lightTheme', 'darkTheme', 'ansiTheme', and 'xcode'. This change standardizes how foreground colors are handled across themes, likely deferring to a default or inherited value, aligning with the PR title's intent to remove foreground settings for themes other than specific ones.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[gemini-code-assist[bot]]

[!WARNING] Gemini encountered an error creating the review. You can try again by commenting /gemini review.

[github-actions[bot]]

Size Change: -30 B (0%)

Total Size: 21.6 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	21.6 MB	-30 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[miguelsolorio]

Did you intend to unset the foreground for all themes? I think we just need to unset the default dark/light, the others are fine because they're customer themes IMO.

[jacob314]

Fixed so we only remove the color from the ansi themes and the default themes. I think it was an error for the ansi theme to hard code white as the foreground instead of leaving it blank to maximize compatibility.