google-gemini
Fix bug in the shellExecutionService resulting in both truncation and 3X bloat
Fix bug in the shellExecutionService resulting in the following P0 issues:
- Only the last 1000 lines of shell output are ever sent even if the output is longer.
- Every line in shell output is padded with spaces to the column width of the terminal resulting in about 3X the total tokens for the commands/frontend.toml example included in this PR.
Summary of Changes
Hello @jacob314, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves two critical issues within the shellExecutionService that previously led to incomplete command outputs and excessive whitespace. By introducing a configurable scrollback buffer and refining the output processing logic, the service can now accurately capture and display extensive command results without truncation or artificial padding. These improvements are essential for supporting new CLI functionalities that generate large amounts of output.
Highlights
- Output Truncation Fix: The shell execution service no longer arbitrarily truncates command output to 1000 lines. It now respects a configurable scrollback limit, defaulting to a significantly larger buffer of 300,000 lines, ensuring full output capture for large commands.
- Whitespace Padding Fix: Output lines are no longer automatically padded with spaces to the terminal's column width. This change reduces the total token count for command outputs and correctly preserves any explicit trailing whitespace, improving output fidelity.
- Enhanced Test Coverage: New comprehensive test cases have been added to validate the correct handling of large outputs (up to 10,000 lines), verify the absence of unnecessary whitespace padding, and confirm the proper functioning of the new scrollback limit.
Ignored Files
- Ignored by pattern:
.gemini/**(2)- .gemini/commands/frontend.toml
- .gemini/commands/full-context.toml
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
![gemini-code-assist[bot] avatar](https://avatars.githubusercontent.com/in/956858?v=4 "Published by a pub.dev verified publisher"){kind=small}
Size Change: +257 B (0%)
Total Size: 21.5 MB
ℹ️ View Unchanged
| Filename | Size | Change |
|---|---|---|
./bundle/gemini.js |
21.5 MB | +257 B (0%) |
./bundle/sandbox-macos-permissive-closed.sb |
1.03 kB | 0 B |
./bundle/sandbox-macos-permissive-open.sb |
890 B | 0 B |
./bundle/sandbox-macos-permissive-proxied.sb |
1.31 kB | 0 B |
./bundle/sandbox-macos-restrictive-closed.sb |
3.29 kB | 0 B |
./bundle/sandbox-macos-restrictive-open.sb |
3.36 kB | 0 B |
./bundle/sandbox-macos-restrictive-proxied.sb |
3.56 kB | 0 B |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
✅ Patch workflow(s) dispatched successfully!
📋 Details:
- Channels:
stable,preview - Commit:
d284fa66c01d557e355931d3bb826098daa9c50e - Workflows Created: 2
🔗 Track Progress:
🚀 Patch PR Created!
📋 Patch Details:
- Environment:
prod - Channel:
stable→ will publish to npm taglatest - Commit:
d284fa66c01d557e355931d3bb826098daa9c50e - Hotfix Branch:
hotfix/v0.19.1/0.19.2/stable/cherry-pick-d284fa6/pr-14545 - Hotfix PR: #14558
- ⚠️ Status: Cherry-pick conflicts detected - manual resolution required
📝 Next Steps:
- ⚠️ Resolve conflicts in the hotfix PR first: #14558
- Test your changes after resolving conflicts
- Once merged, the patch release will automatically trigger
- You'll receive updates here when the release completes
🔗 Track Progress:
🚀 Patch PR Created!
📋 Patch Details:
- Environment:
prod - Channel:
preview→ will publish to npm tagpreview - Commit:
d284fa66c01d557e355931d3bb826098daa9c50e - Hotfix Branch:
hotfix/v0.20.0-preview.0/0.20.0-preview.1/preview/cherry-pick-d284fa6/pr-14545 - Hotfix PR: #14559
- ⚠️ Status: Cherry-pick conflicts detected - manual resolution required
📝 Next Steps:
- ⚠️ Resolve conflicts in the hotfix PR first: #14559
- Test your changes after resolving conflicts
- Once merged, the patch release will automatically trigger
- You'll receive updates here when the release completes
🔗 Track Progress:
🚀 Patch Release Started!
📋 Release Details:
- Environment:
prod - Channel:
preview→ publishing to npm tagpreview - Version:
v0.20.0-preview.0 - Hotfix PR: Merged ✅
- Release Branch:
release/v0.20.0-preview.0-pr-14545
⏳ Status: The patch release is now running. You'll receive another update when it completes.
🔗 Track Progress:
🚀 Patch Release Started!
📋 Release Details:
- Environment:
prod - Channel:
stable→ publishing to npm taglatest - Version:
v0.19.1 - Hotfix PR: Merged ✅
- Release Branch:
release/v0.19.1-pr-14545
⏳ Status: The patch release is now running. You'll receive another update when it completes.
🔗 Track Progress:
✅ Patch Release Complete!
📦 Release Details:
- Version:
0.20.0-preview.1 - NPM Tag:
preview - Channel:
preview - Dry Run: false
🎉 Status: Your patch has been successfully released and published to npm!
📝 What's Available:
- GitHub Release: View release v0.20.0-preview.1
- NPM Package:
npm install @google/gemini-cli@preview
🔗 Links:
✅ Patch Release Complete!
📦 Release Details:
- Version:
0.19.2 - NPM Tag:
latest - Channel:
stable - Dry Run: false
🎉 Status: Your patch has been successfully released and published to npm!
📝 What's Available:
- GitHub Release: View release v0.19.2
- NPM Package:
npm install @google/gemini-cli@latest
🔗 Links: