Avoid triggering refreshStatic unless there really is a banner to display.

[jacob314]

Summary

We were calling staticRefresh even if the banner wouldn't be shown to a user or there wasn't a banner to show. This resulted in an extra frame of flicker and caused us to clear the static content from before the app was rendered even when it didn't need to be cleared.

Fyi @bbiggs who reported this.

[gemini-code-assist[bot]]

Summary of Changes

Hello @jacob314, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the application's UI rendering by implementing a conditional refresh mechanism for static elements. It ensures that the refreshStatic() function, which clears and redraws parts of the terminal, is only executed when there is actual banner content to be displayed. This change improves efficiency by preventing redundant rendering cycles and unnecessary terminal operations when no banner is present.

Highlights

• Conditional UI Refresh: The application now intelligently avoids triggering a refreshStatic() operation unless there is actual banner content to display, preventing unnecessary terminal clear operations.
• New useBanner Hook: A new custom React hook, useBanner, has been introduced to centralize and manage the logic for determining the currently active banner text based on default and warning messages.
• Regression Test Added: A new regression test ensures that the refreshStatic mechanism (specifically, clearTerminal) is not invoked when the banner texts are empty, validating the intended optimization.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[github-actions[bot]]

Size Change: +347 B (0%)

Total Size: 21.5 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	21.5 MB	+347 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}