gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

Implement initial color scheme/theming support

Open kairosci-dev opened this issue 1 month ago • 1 comments

Summary

This PR improves syntax highlighting in the default UI themes (DefaultDark and DefaultLight), enhancing code readability by updating colors for function names and object properties. It also fixes an issue with diff highlighting where background colors were being ignored and removes an unused @ts-expect-error directive.

Details

  • Fix: Remove unused @ts-expect-error directive:
    • Removed an unused @ts-expect-error directive in CodeColorizer.color.test.tsx.
  • DefaultDark Theme Updates:
    • Replaced backgroundColor with color for hljs-addition and hljs-deletion to correctly highlight diffs (renderer ignored background colors).
    • Changed hljs-title to AccentGreen for better visibility of function names.
    • Added hljs-property support using LightBlue to highlight object properties.
  • DefaultLight Theme Updates:
    • Added hljs-property support using AccentRed for consistent highlighting.

Related Issues

How to Validate

  1. Build the project: npm run build
  2. Run the CLI: npm start (or your preferred launch command).
  3. Check General Highlighting: Ask the CLI to generate some code with a function and an object (e.g., "Write a JavaScript function that takes an object as an argument"). Verify that function names are green and properties are blue (in Dark mode).
  4. Check Diff Highlighting: Make a change to a file and ask the CLI to show the diff (e.g., "Show me the diff for [file]"). Verify that additions and deletions are clearly colored and readable.
  5. Switch Themes: If possible, switch to the Light theme and verify the property highlighting is red.

Pre-Merge Checklist

  • [ ] Updated relevant documentation and README (if needed)
  • [ ] Added/updated tests (if needed)
  • [x] Noted breaking changes (if any)
  • [x] Validated on required platforms/methods:
    • [x] MacOS
      • [x] npm run
      • [x] npx
      • [ ] Docker
      • [ ] Podman
      • [ ] Seatbelt
    • [ ] Windows
      • [ ] npm run
      • [ ] npx
      • [ ] Docker
    • [x] Linux
      • [x] npm run
      • [x] npx
      • [ ] Docker

kairosci-dev avatar Nov 29 '25 12:11 kairosci-dev

Summary of Changes

Hello @kairosci, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces initial refinements to the application's color schemes, focusing on enhancing syntax highlighting within code displays. It specifically adds styling for code properties in both light and dark themes and updates how added and deleted lines are visually represented in the dark theme, transitioning from background colors to text colors for better integration with the overall theme.

Highlights

  • Syntax Highlighting for Properties: Added specific styling for hljs-property to both the DefaultLight and DefaultDark themes, enhancing the visual distinction of code properties.
  • Dark Theme Title Color Update: Modified the hljs-title color within the DefaultDark theme to use AccentGreen, improving consistency and readability.
  • Refined Addition/Deletion Styling in Dark Theme: Adjusted the styling for hljs-addition and hljs-deletion in the DefaultDark theme to apply AccentGreen and AccentRed as text colors, respectively, moving away from background colors for these elements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 29 '25 12:11 gemini-code-assist[bot]