gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

feat(settings): rename disable* toggles to enable* for consistency

Open afarber opened this issue 1 month ago • 2 comments

Summary

Standardize boolean toggle settings to use positive "Enable X" naming instead of "Disable X" to avoid double negatives and improve UX consistency. Adds automatic migration for existing user configurations.

Details

Renamed 4 settings with inverted boolean logic:

  • general.disableAutoUpdate -> general.enableAutoUpdate (default: true)
  • general.disableUpdateNag -> general.enableUpdatePrompts (default: true)
  • context.fileFiltering.disableFuzzySearch -> context.fileFiltering.enableFuzzySearch (default: true)
  • ui.accessibility.disableLoadingPhrases -> ui.accessibility.enableLoadingPhrases (default: true)

Migration logic in migrateDeprecatedSettings() automatically converts old settings with inverted values. Old configs like disableAutoUpdate: true become enableAutoUpdate: false

Note: security.disableYoloMode intentionally kept as-is since "disable" framing is appropriate for a dangerous mode.

Related Issues

Fixes #14035 and #15013

How to Validate

  1. Fresh install: Run gemini and verify settings dialog shows "Enable Auto Update", "Enable Loading Phrases", etc.
  2. Migration test: Create ~/.gemini/settings.json with old format:
{
  "general": {
    "disableAutoUpdate": true,
    "disableUpdateNag": true
  },
  "ui": {
    "accessibility": {
      "disableLoadingPhrases": true
    }
  },
  "context": {
    "fileFiltering": {
      "disableFuzzySearch": true
    }
  },
  "security": {
    "disableYoloMode": true
  }
}
  1. Run gemini, then check settings - should show: - "Enable Auto Update" as OFF - "Enable Update Prompts" as OFF - "Enable Loading Phrases" as OFF - "Enable Fuzzy Search" as OFF - "Disable YOLO Mode" as ON (unchanged, kept as-is)
  2. Run npm run preflight - all tests pass

Pre-Merge Checklist

  • [x] Updated relevant documentation and README (if needed)
  • [x] Added/updated tests (if needed)
  • [ ] Noted breaking changes (if any)
  • [x] Validated on required platforms/methods:
    • [x] MacOS
      • [x] npm run
      • [ ] npx
      • [ ] Docker
      • [ ] Podman
      • [ ] Seatbelt
    • [ ] Windows
      • [ ] npm run
      • [ ] npx
      • [ ] Docker
    • [ ] Linux
      • [ ] npm run
      • [ ] npx
      • [ ] Docker

afarber avatar Nov 29 '25 11:11 afarber

Summary of Changes

Hello @afarber, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors several boolean configuration settings to enhance user experience and consistency. By standardizing naming conventions from 'disableX' to 'enableX' and inverting their default values, the system avoids confusing double negatives. Crucially, it includes robust migration logic to ensure that existing user settings are automatically updated without data loss or manual intervention, making the transition transparent for users.

Highlights

  • Setting Renaming for Consistency: Four boolean settings have been renamed from a 'disableX' format to an 'enableX' format to improve UX consistency and avoid double negatives. These include general.disableAutoUpdate to general.enableAutoUpdate, general.disableUpdateNag to general.enableUpdatePrompts, context.fileFiltering.disableFuzzySearch to context.fileFiltering.enableFuzzySearch, and ui.accessibility.disableLoadingPhrases to ui.accessibility.enableLoadingPhrases.
  • Inverted Default Values: Along with the renaming, the default values for these settings have been inverted. For example, general.enableAutoUpdate now defaults to true (whereas disableAutoUpdate defaulted to false).
  • Automatic Migration Logic: Automatic migration logic has been implemented in migrateDeprecatedSettings() to seamlessly convert existing user configurations. If an old setting like disableAutoUpdate: true is found, it will be automatically converted to enableAutoUpdate: false.
  • Documentation and Test Updates: All relevant documentation, settings schemas, and test files have been updated to reflect the new setting names, their inverted logic, and the migration process.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 29 '25 11:11 gemini-code-assist[bot]