gemini-cli icon indicating copy to clipboard operation
gemini-cli copied to clipboard

fix(cli): send gemini-cli version as mcp client version

Open dsp opened this issue 1 month ago • 3 comments

Summary

Previously we were sending a constant version string to MCP servers. This makes it harder for servers to understand which gemini-cli client they are working with. While this is purely informational, it might help server operators to understand their clients better.

Changes

  • Thread clientVersion from CLI through Config to McpClientManager and McpClient
  • Pass the actual gemini-cli version (from getCliVersion()) to the MCP SDK Client constructor
  • Update all related tests to match the new constructor signature

Test Plan

  • All existing tests pass (3,275 tests)
  • TypeScript compilation successful
  • Verified version flows correctly through the system

dsp avatar Nov 19 '25 13:11 dsp

Summary of Changes

Hello @dsp, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the gemini-cli's communication with MCP servers by implementing dynamic client version reporting. Previously, a generic version string was sent, limiting server operators' ability to identify and troubleshoot client-side issues. By passing the actual CLI version through the configuration and client management layers, this change provides valuable diagnostic information, improving server-side visibility and potentially aiding in better client support and analysis.

Highlights

  • Client Version Reporting: The gemini-cli now sends its actual version to MCP servers, moving from a static placeholder to dynamic, accurate client identification.
  • Version Propagation: The clientVersion is systematically threaded through the Config object, McpClientManager, and McpClient to ensure it reaches the server.
  • Test Updates: All relevant unit tests have been updated to accommodate the new constructor signatures and verify the correct flow of the client version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Nov 19 '25 13:11 gemini-code-assist[bot]

Mind fixing the conflicts @dsp then I'll give a quick pass and get this merged in 👍

jackwotherspoon avatar Dec 05 '25 15:12 jackwotherspoon

@jackwotherspoon done

dsp-ant avatar Dec 10 '25 19:12 dsp-ant