fix(client): Correctly latch hasFailedCompressionAttempt flag

[pareshjoshij]

The hasFailedCompressionAttempt flag is intended to prevent the client from wastefully retrying automatic (non-forced) compression after it has already failed once with an inflated token count.

The previous logic (this.hasFailedCompressionAttempt = !force && true;) incorrectly reset this flag to false if a subsequent forced compression attempt also failed.

This commit modifies the condition to only set the flag to true on a non-forced failure (&& !force). This ensures the flag latches correctly for the remainder of the session as intended, preventing inefficient retries and token usage.

Summary

Details

Related Issues

• Fixes #13058

How to Validate

Pre-Merge Checklist

• [ ] Updated relevant documentation and README (if needed)
• [ ] Added/updated tests (if needed)
• [ ] Noted breaking changes (if any)
• [ ] Validated on required platforms/methods:
  • [ ] MacOS
    • [ ] npm run
    • [ ] npx
    • [ ] Docker
    • [ ] Podman
    • [ ] Seatbelt
  • [ ] Windows
    • [ ] npm run
    • [ ] npx
    • [ ] Docker
  • [ ] Linux
    • [ ] npm run
    • [ ] npx
    • [ ] Docker

[gemini-code-assist[bot]]

Summary of Changes

Hello @pareshjoshij, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in the client's compression mechanism where a critical flag, intended to prevent repeated failed compression attempts, was being incorrectly reset. The fix ensures that this flag maintains its state as intended, leading to more efficient operation by avoiding unnecessary retries after an initial compression failure.

Highlights

• Compression Flag Logic: Corrected the logic for the 'hasFailedCompressionAttempt' flag to ensure it latches properly after a non-forced compression failure, preventing wasteful retries and inefficient token usage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[pareshjoshij]

/gemini review

[pareshjoshij]

Hi @scidomino,

I noticed you have been active on recent PRs, so I wanted to bring this to your attention.

This PR (#13002) fixes the hasFailedCompressionAttempt latching bug (#13058) and now includes the specific unit tests requested by the gemini-code-assist bot. The bot has already reviewed the latest changes and marked them as "looking good."

It has been pending for a while, so could you please take a look or approve the workflows so we can get the CI checks running?

Thanks!

[pareshjoshij]

@gundermanc Could you please review this? It fixes the issue where the compression flag wasn't latching properly, which prevents unnecessary retry attempts. The bot has already verified the logic is sound.