Formatting Guess_the_shape.ipynb.ipynb Notebook
Check out this pull request on ![]()
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
View / edit / reply to this conversation on ReviewNB
andycandy commented on 2025-04-04T16:39:10Z ----------------------------------------------------------------
Line #3. model = MODEL_ID,
As @Giom V. mentioned, function params don't need extra spaces, so it should always be be:
response = client.models.generate_content( model=MODEL_ID, contents=contents, config=config )
This notebook was already migrated a few weeks ago, you might need to rename this PR to something more appropriate.
View / edit / reply to this conversation on ReviewNB
Giom-V commented on 2025-04-07T12:34:56Z ----------------------------------------------------------------
Line #2. contents = [
Nit: can you add a line line between the import and the code?
View / edit / reply to this conversation on ReviewNB
Giom-V commented on 2025-04-07T12:36:11Z ----------------------------------------------------------------
I think we should keep >=1.0.0 whenever it works and only indicate a higher minimum value when the notebooks are using recent features.
@Giom-V Thanks for the Review ;)
Thanks @omkenge. Approved and merged!