cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Updated Providing_base_cases.ipynb to use google-genai

Open Shi-pra-19 opened this issue 8 months ago • 6 comments

Updated module google-generativeai to use google-genai Refactored imports

Shi-pra-19 avatar Apr 03 '25 08:04 Shi-pra-19

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks for the submission @Shi-pra-19! It's the first one if I'm not mistaken 🥳

I just added a couple of minor comments to make the notebook easier to understand.

Can you also check the format failures. It is likely because you haven't run the formatting script.

Thanks again!

Giom-V avatar Apr 03 '25 14:04 Giom-V

@Giom-V Thank you for the review! This one is my second submission—my first one was #642. 🥳

I’ve added indentation and run the formatting script. Let me know if there are any more improvements needed.

Also, please take a look at #642 as well—I fixed the indentation there too.

Shi-pra-19 avatar Apr 03 '25 22:04 Shi-pra-19

Fixed it. Let me know if I missed anything.

Shi-pra-19 avatar Jun 04 '25 02:06 Shi-pra-19

Fixed it. Let me know if I missed anything.

Looks great overall! Just one small thing, could you avoid bumping the @google/genai package to 1.7.0? Since the current code works with versions as low as 1.0.0, keeping it more broadly compatible would be ideal. Once that's updated, we can get this merged right away :)

andycandy avatar Jun 04 '25 06:06 andycandy

Looks good to me. @Giom-V

andycandy avatar Jun 18 '25 06:06 andycandy