cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Updated Basic_Evaluation.ipynb to use google-genai

Open Shi-pra-19 opened this issue 8 months ago • 4 comments

Updated module google-generativeai to use google-genai Refactored imports Modified how configs are being assigned to models

Shi-pra-19 avatar Apr 02 '25 19:04 Shi-pra-19

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Apr 02 '25 19:04 google-cla[bot]

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks for the submission. @Shi-pra-19!

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the format failures and fix them (likely because you haven't run the formatting script) ?

And last thing, before you run the formatting script, can you also run all the cells to make sure everything works as expected? The output cells do not seem to have been updated.

Thanks again!

Giom-V avatar Apr 03 '25 08:04 Giom-V

@Giom-V Thanks for the review!

I went through your comments and updated the notebook based on that. I also ran the formatting script and re-ran all the cells.

Let me know if I missed anything.

Shi-pra-19 avatar Apr 03 '25 13:04 Shi-pra-19

Thanks for the submission @Shi-pra-19 and sorry for the time it took for the reviews.

Giom-V avatar Apr 29 '25 13:04 Giom-V