cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Add new Zero Shot Prompting

Open omkenge opened this issue 8 months ago • 11 comments

omkenge avatar Apr 02 '25 05:04 omkenge

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

This notebook is being migrated in PR #621 by @Giom-V and @ROHANDWIVEDI2005, trying to merge examples in the old module way might cause this PR to be closed. Please modify your PR to incorporate the latest formatting

andycandy avatar Apr 02 '25 10:04 andycandy

I can see that you are trying to add new examples to zero_shot_prompting.ipynb but currently this notebook is using the old sdk. I have already made a pr to update it. You can make a pr after that one is merged.

ROHANDWIVEDI2005 avatar Apr 02 '25 11:04 ROHANDWIVEDI2005

I can see that you are trying to add new examples to zero_shot_prompting.ipynb but currently this notebook is using the old sdk. I have already made a pr to update it. You can make a pr after that one is merged.

@omkenge As @ROHANDWIVEDI2005 said, I think it's better to wait for #621 to be merged and then we'll revisit your PR.

Giom-V avatar Apr 02 '25 11:04 Giom-V

@omkenge #621 has been merged.

Giom-V avatar Apr 03 '25 13:04 Giom-V

@Giom-V Done

omkenge avatar Apr 03 '25 16:04 omkenge

Sorry for messy stuffs ...

omkenge avatar Apr 03 '25 16:04 omkenge

@omkenge I think you made some mistakes when merging. Your examples are also still using the old SDK. I'll let you update all of that before reviewing again.

Giom-V avatar Apr 03 '25 19:04 Giom-V

@Giom-V Apologies for the inconvenience :(. There were some mistakes on my part, but I believe everything is correct now. :)

omkenge avatar Apr 03 '25 20:04 omkenge

@omkenge everything looks fine code-wise. Can you just run all the cells (it should replace the outputs) and then format the notebooks before I can submit?

Giom-V avatar Apr 04 '25 14:04 Giom-V

@Giom-V Thanks for your review ;)

omkenge avatar Apr 07 '25 17:04 omkenge

Thanks @omkenge. Approved and merged. But if you are curious, please check what I updated before submitting.

Giom-V avatar Apr 23 '25 14:04 Giom-V