cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Merged `examples/function_calling_config.ipynb` into `examples/function_calling.ipynb` notebook

Open andycandy opened this issue 8 months ago • 10 comments

~Much stuff has changed, so I'm unsure what precisely to print in each cell. So I took some stuff from ../quickstarts/Function_calling.ipynb route, as it's pretty well formatted, to print all the to and fro that went in the background for performing every user request~

  • ~Updated SDK imports~
  • Merged function_calling_config into function_calling notebook
  • lint checked
  • nbfmt

andycandy avatar Apr 01 '25 18:04 andycandy

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@andycandy I'm sorry since you already worked on that notebook, but I think the best would be to move those explanations to the function calling notebook as I don't think it really makes sense to have 2 separate ones. I'll still add some comments in the current notebook so that you can do it right the first time :)

Giom-V avatar Apr 02 '25 14:04 Giom-V

@andycandy I'm sorry since you already worked on that notebook, but I think the best would be to move those explanations to the function calling notebook as I don't think it really makes sense to have 2 separate ones. I'll still add some comments in the current notebook so that you can do it right the first time :)

I have merged both these notebooks into one @Giom-V

andycandy avatar Apr 02 '25 14:04 andycandy

Thanks a lot @andycandy. I was not expecting you to start refactoring the notebook that much (I was expecting a copy-pasting of the other notebook at the end of this one).

That wasn't an easy review to do (at work I'd have jumped into a call to explain live), so I'm not sure if my comments are really clear, but in the end it all comes down to the order in which we want to introduce and explain stuff.

I'd say we need to start simple, with a simple example just showing the final output, that can be used to introduce what FC is, why using chat, how to define the functions, etc... Then we should explain that with the SDK it has Automatic FC, then show manual FC if auto-FC is not available, then I guess the order is up to you between advanced use-cases (parallel/Compositional) and the modes. The whole goal is to take the reader by the hand and explain the concepts in order. In doubt you can just refer to the documentation does it as it was reworked last week.

Giom-V avatar Apr 03 '25 09:04 Giom-V

@Giom-V, Thank you for giving such an in-depth review. I made notes for all the changes you wanted, restructured the whole notebook, and checked everything to ensure they are as you asked them to be. Please skim through them once.

andycandy avatar Apr 03 '25 19:04 andycandy

@andycandy I made a couple of comments but it's shaping well. Now the progression of the guide makes sense. We're getting there :)

Giom-V avatar Apr 04 '25 16:04 Giom-V

@Giom-V Tried to implement all your suggestions, however, I'd request you to look into that 'any' mode function_calling_config parameters issue

andycandy avatar Apr 04 '25 18:04 andycandy

@Giom-V Tried to implement all your suggestions, however, I'd request you to look into that 'any' mode function_calling_config parameters issue

@andycandy I think we're good, except the little addition to explain what maximum_remote_calls does and why you need to set it when using ANY.

Giom-V avatar Apr 07 '25 09:04 Giom-V

Ignore the format and lint errors, they are as expected.

Giom-V avatar Apr 07 '25 09:04 Giom-V

@Giom-V Done!

andycandy avatar Apr 07 '25 09:04 andycandy

Sorry @andycandy I think I modified some things for the 2.5 Flash launches and the merge is too complicated to do on github.

Giom-V avatar Apr 18 '25 15:04 Giom-V

No worries @Giom-V, I can fix it :) Please gimme few mins

andycandy avatar Apr 18 '25 18:04 andycandy

Done!

andycandy avatar Apr 18 '25 18:04 andycandy

Sorry @andycandy I think I modified some things for the 2.5 Flash launches and the merge is too complicated to do on github.

Also, Is this the case with all other PRs submitted in this repo? I can fix their mergability as well if you say

andycandy avatar Apr 18 '25 19:04 andycandy

@andycandy Finally merged! Thanks for the hard work!

Giom-V avatar Apr 28 '25 08:04 Giom-V

My pleasure!

andycandy avatar Apr 28 '25 10:04 andycandy