cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

feat: Update Search_Wikipedia_using_ReAct.ipynb notebook to use google-genai SDK

Open Raunak2024 opened this issue 8 months ago • 12 comments

This Pull Request addresses Search_Wikipedia_using_ReAct.ipynb notebook mentioned in the issue #446 and migrates it from the old google-generativeai SDK to the new google-genai SDK.

Raunak2024 avatar Mar 25 '25 15:03 Raunak2024

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hi @markmcd @andycandy, I have done the necessary changes to the notebook as suggested. Please review the updates and do let me know. Thanks!

Raunak2024 avatar Mar 31 '25 09:03 Raunak2024

Thanks for the submission @Raunak2024.

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). If you see a lint error reported in the template notebook, just ignore it, it's because of a CL you merged with.

And last thing, before you run the formatting script, can you also run all the cells to make sure everything works as expected?

Thanks again!

Giom-V avatar Mar 31 '25 13:03 Giom-V

And thanks @andycandy for helping with the review!!

Giom-V avatar Mar 31 '25 13:03 Giom-V

Hi @Raunak2024 , just following up to see if you are still working on this. If not, I am happy to take it over and continue from where you left off!

KSruthiVel avatar Apr 06 '25 21:04 KSruthiVel

Hi @Raunak2024 , just following up to see if you are still working on this. If not, I am happy to take it over and continue from where you left off!

Let's give @Raunak2024 24 hours and without an update you'll be free to work on this notebook.

Giom-V avatar Apr 07 '25 09:04 Giom-V

Greetings @KSruthiVel @Giom-V I am busy due to college work for some time. So I am planning to work on checking the lint and format failures and fixing them by the end of this week as suggested. Moreover, I have run all the cells and everything seems to work as expected. Thanks

Raunak2024 avatar Apr 09 '25 06:04 Raunak2024

Greetings @KSruthiVel @Giom-V I am busy due to college work for some time.

Hello @Raunak2024, did you had time to update the notebook?

Giom-V avatar Apr 22 '25 14:04 Giom-V

Hi @Giom-V, Thanks for checking in. There seems to be an issue while running the linting script for fixing the linting issues on colab. I'm trying to fix it and will push the updated code by this weekend once it is done. Thanks again for your patience!

Raunak2024 avatar Apr 24 '25 16:04 Raunak2024

Hi @Giom-V. I am still running into the same issues with the linting script on Colab that I mentioned last time. Would you have any specific advice on resolving that, or should I perhaps push what I have so far for someone else to fix the linting?

Raunak2024 avatar Apr 27 '25 15:04 Raunak2024

No worries about the lint issue, if you check the details that's because it for some reason checks the template which raises an error.

Giom-V avatar Apr 27 '25 18:04 Giom-V

Okay, Thanks @Giom-V for the clarification. Good to know that's the expected cause and not a major worry right now. In that case, should I push the updated code?

Raunak2024 avatar Apr 29 '25 18:04 Raunak2024