cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Updated examples/Voice_memos.ipynb to use google-genai SDK

Open prajwxlk opened this issue 9 months ago • 12 comments

prajwxlk avatar Mar 22 '25 15:03 prajwxlk

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Thanks @Chamikajaya for the submission and sorry for the delayed review.

Sadly that file was already being worked on in #589 and since the other PR is older I tend to give it priority (that's a rule that's as good as any other I guess).

That said, since feedback is the best way to improve, I just added a couple of minor comments to make the notebook easier to understand and to maintain.

I'll close the PR for now, but if for some reason #589 does not progress I'll reopen this one.

Giom-V avatar Mar 31 '25 13:03 Giom-V

I'm really sorry Giom-V, I'll make sure to do a thorough check before creating a new PR. Thank you for the feedback!

prajwxlk avatar Mar 31 '25 16:03 prajwxlk

Hi @Giom-V, It seems that the PR #589 hasn't responded yet to any of the further communications. Can you please consider my PR again for Voice_memos.ipynb notebook?

prajwxlk avatar Apr 15 '25 19:04 prajwxlk

Hi @Giom-V, It seems that the PR #589 hasn't responded yet to any of the further communications. Can you please consider my PR again for Voice_memos.ipynb notebook?

Sure, I will

Giom-V avatar Apr 15 '25 21:04 Giom-V

Hello @Giom-V, I have implemented the changes according to your suggestions in the code. Please let me know if any more changes need to be done. Thank you for your feedback!

prajwxlk avatar Apr 16 '25 15:04 prajwxlk

Hello @prajwxlk, I made some minor comments. Can you work on them and I'll approve the PR?

Giom-V avatar Apr 23 '25 15:04 Giom-V

Hello @Giom-V, I have implemented all of the suggestions you have provided me with. Thank you for your support!

prajwxlk avatar Apr 25 '25 09:04 prajwxlk

@prajwxlk You just need to run the formatting script and we're good to go!

Giom-V avatar Apr 29 '25 15:04 Giom-V

@Giom-V , I'm really sorry for not doing this earlier. Completely slipped my mind. I have successfully formatted the Notebook. Thank you so much!

prajwxlk avatar Apr 29 '25 15:04 prajwxlk

Hello @Giom-V, do let me know if any other changes need to be made otherwise the PR is ready to be merged. Thank you for your support!

prajwxlk avatar May 07 '25 14:05 prajwxlk

Hello @andycandy, I have implemented the changes you have suggested. Thank you for your feedback!

prajwxlk avatar Jun 04 '25 20:06 prajwxlk

@Giom-V @andycandy Please merge this PR.

prajwxlk avatar Dec 07 '25 05:12 prajwxlk

Thanks you @prajwxlk and sorry for the time it took.

Giom-V avatar Dec 09 '25 16:12 Giom-V