cookbook icon indicating copy to clipboard operation
cookbook copied to clipboard

Fixes for Run on multiple Images

Open manojssmk opened this issue 1 year ago • 4 comments

This notebook demonstrates how to prompt multiple images and obtain a summary for each image in JSON format using threading.

Fix : #201

manojssmk avatar Sep 26 '24 08:09 manojssmk

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Hello @manojssmk,

Thanks for the PR. I'll have a look in details this week and I'll likely add a couple of things, like a "what's next" section at the end (cf. template).

In the meantime, could you try to fix the lint issues? It's mainly changing all the "we"s into "you"s.

Thanks!

Giom-V avatar Oct 02 '24 09:10 Giom-V

A couple of quick drive-by comments from me:

  1. Please make sure you comply with the licenses when distributing third-party content (the images)
  2. Run pyink & nbfmt on the notebook to keep the code style-consistent
  3. I'm a little concerned that the code is "too smart" - does it need to demonstrate batching images into single prompts?
    • I would either put one image per request and a simple thread pool,
    • Or can you just put them all in one prompt? If performance is the point, then this is only 1 request, and it could show off the 2M context nicely.
    • Either way, it would help to understand what you are trying to demonstrate.

markmcd avatar Oct 18 '24 00:10 markmcd

Marking this pull request as stale since it has been open for 14 days with no activity. This PR will be closed if no further activity occurs.

github-actions[bot] avatar Nov 01 '24 22:11 github-actions[bot]

This pull request was closed because it has been inactive for 27 days. Please open a new pull request if you need further assistance. Thanks!

github-actions[bot] avatar Nov 14 '24 22:11 github-actions[bot]