visibility scale bug?

[jtatusko]

class Visibility(enum.IntEnum):
  """Values for the `visibility` feature layers."""
  HIDDEN = 0
  SEEN = 1
  VISIBLE = 2

https://github.com/deepmind/pysc2/blob/master/pysc2/lib/features.py#L262

should scale be set to three, since there are only three possible values of visibility, or am i misunderstanding the purpose of the scale property?

[jtatusko]

Same for effects enum. The effects are given scale 16 but there are only 12 possible values in the enum

[jtatusko]

Should the effects enum also start at 0 like the rest? https://github.com/deepmind/pysc2/blob/master/pysc2/lib/features.py#L64

[tewalds]

You are correct. Unfortunately this is tough for us to fix given that our agents depend on this... Sorry.