optax icon indicating copy to clipboard operation
optax copied to clipboard

feat - Implemented Lion Optimizer and Tests scripts

Open raghulchandramouli opened this issue 1 month ago • 5 comments

Hey as per the issue i have raised an pull request for the implementation of lion_optimizer, please check the code and Merge

Thanks and Regards, RaghulChandramouli

raghulchandramouli avatar Oct 24 '25 17:10 raghulchandramouli

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 24 '25 17:10 google-cla[bot]

Check this https://optax.readthedocs.io/en/latest/api/optimizers.html#optax.lion first. Let me know tif you want to change the current implementation.

vroulet avatar Oct 24 '25 22:10 vroulet

Thanks ! Sorry for the delay. Do you think it would be possible to add the smooth option to the current implementation? That way we minimize code duplication and maintenance burden while getting a neat new feature.

Happy to review it then ! (ping me when it's ready)

vroulet avatar Nov 14 '25 18:11 vroulet

I have raised a new branch and added all the changes https://github.com/google-deepmind/optax/pull/1497

Please track this @vroulet

raghulchandramouli avatar Nov 16 '25 12:11 raghulchandramouli

https://github.com/google-deepmind/optax/pull/1497 does not address Vincent's comments. See my comment there.

rdyro avatar Nov 16 '25 18:11 rdyro

Closing since it was branched in #1497

vroulet avatar Dec 02 '25 19:12 vroulet