optax icon indicating copy to clipboard operation
optax copied to clipboard

Published 20 hours ago • verified publisher icon google-deepmind

explain what optax.centralize does

Open fabianp opened this issue 1 year ago • 2 comments

Its docstring is extremely poor: https://optax.readthedocs.io/en/latest/api/transformations.html#optax.centralize

  • Explain what centralize means
  • Add a usage example
  • Put reference in correct RST format

fabianp avatar Oct 01 '24 08:10 fabianp

Hi @fabianp , I'm going to start working on this issue, could you assign it to me?

miguelcsx avatar Oct 03 '24 20:10 miguelcsx

thanks for picking this up @miguelcsx !

fabianp avatar Oct 04 '24 07:10 fabianp

Hi, if this issue isn't closed can i work on it?

shreyans413 avatar Feb 28 '25 08:02 shreyans413

Hi, if this issue isn't closed can i work on it?

Definitely! Let me know once you make a PR, thanks!

rdyro avatar Feb 28 '25 18:02 rdyro

I have the PR ready, but i am unable to sign the CLA, it keeps showing server error, is there something i can do about it?

shreyans413 avatar Mar 01 '25 16:03 shreyans413

Filed an internal issue about the CLA. Hang tight.

rni418 avatar Mar 03 '25 17:03 rni418

Alright, please try again?

rni418 avatar Mar 04 '25 08:03 rni418

Hi @fabianp , I'm going to start working on this issue, could you assign it to me?

IronwallxR5 avatar Mar 04 '25 10:03 IronwallxR5

@IronwallxR5 : I think @shreyans413 was already working on it. Keep us posted @shreyans413 😄

fabianp avatar Mar 04 '25 11:03 fabianp

Yes, I was working on this, and I’ve submitted a PR with the updated docstring, explanation, and example. Let me know if any further improvements are needed! :)

shreyans413 avatar Mar 04 '25 12:03 shreyans413

I have already signed the CLA, still its failing the CLA check..

shreyans413 avatar Mar 04 '25 13:03 shreyans413

@shreyans413

I have already signed the CLA, still its failing the CLA check..

Could you force push and try again now?

rdyro avatar Mar 04 '25 17:03 rdyro

I’ve force-pushed the changes, and the CLA issue is now resolved. Let me know if anything else is needed. Thanks!

shreyans413 avatar Mar 04 '25 18:03 shreyans413

Done in #1220

vroulet avatar Mar 12 '25 00:03 vroulet