open_spiel icon indicating copy to clipboard operation
open_spiel copied to clipboard

Published 20 hours ago • verified publisher icon google-deepmind

Incorrect docstring in policy_gradient.py

Open maayanorner opened this issue 2 years ago • 4 comments

https://github.com/deepmind/open_spiel/blob/f4ae28033cc1f92ca4cc9f8bc87477ba9c8c4237/open_spiel/python/algorithms/policy_gradient.py

Hi, The docstring states the critic learning rate is 0.001, but it really defaults to 0.01. It has the same issue in PPO, etc., I guess it's related to some copy-pasting or something similar :)

Thanks

maayanorner avatar Aug 22 '22 09:08 maayanorner

Thanks, good find! Can you submit a PR to fix the instances you found?

lanctot avatar Aug 22 '22 10:08 lanctot

Sure, I will work on it as soon as I can.

maayanorner avatar Aug 22 '22 14:08 maayanorner

@lanctot I have made the appropriate changes and made a PR for that, Please Merge it if this is correct, otherwise let me know if any modifications need to be made.

Warlord-K avatar Oct 07 '22 08:10 Warlord-K

Perfect thanks. Should be merged on Monday.

lanctot avatar Oct 07 '22 09:10 lanctot