mujoco icon indicating copy to clipboard operation
mujoco copied to clipboard

Non-file Makefile targets should have .PHONY

Open engnadeau opened this issue 3 years ago • 4 comments

  • See https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html and https://stackoverflow.com/questions/2145590/what-is-the-purpose-of-phony-in-a-makefile for details
  • Also, since .PHONY targets are cumulative, it's often cleaner to declare the phony next to the command, instead of a giant blob

engnadeau avatar Oct 25 '21 15:10 engnadeau

@ggulgulia, we can synchronize our PRs (https://github.com/deepmind/mujoco/pull/26)

engnadeau avatar Oct 25 '21 15:10 engnadeau

Hi @nnadeau , thanks for the suggestion about .PHONY targets. I applied it as a commit

ggulgulia avatar Oct 25 '21 16:10 ggulgulia

If it's OK I'm going to hold off on merging this PR for a bit since we're currently investigating CMake.

saran-t avatar Oct 25 '21 23:10 saran-t

@saran-t for sure; cmake will definitely add more power (and a little complexity).

engnadeau avatar Oct 26 '21 18:10 engnadeau