mujoco icon indicating copy to clipboard operation
mujoco copied to clipboard

[Unity plugin] Remove sensor noise properties

Open Balint-H opened this issue 3 months ago • 3 comments

Remove references in MjGlobalOptions and sensor base class to the deprecated sensornoise attribute.

Balint-H avatar May 10 '24 15:05 Balint-H

I think it could be easily misleading, e.g. they have learned some RL controller but want to make it more robust with sensor noise, they see the option and just put a value there without it actually having the intended effect. In any component they use to collect sensor readings with, they can inject noise there just as well.

Balint-H avatar May 12 '24 08:05 Balint-H

Could you please run the tests? Both MjBaseSensorTests and MjcfImporterTests make references to this now-absent field.

erez-tom avatar May 13 '24 10:05 erez-tom

I forgot about the test framework implementation in the package! From now on I'll make sure to run them before a PR, and I'll amend this one.

Balint-H avatar May 13 '24 10:05 Balint-H