mujoco icon indicating copy to clipboard operation
mujoco copied to clipboard

Fix docs for the record command

Open jmargeta opened this issue 11 months ago • 2 comments

Renames the non-existent "render" command to "record"

jmargeta avatar Mar 06 '24 00:03 jmargeta

Thanks!

Obviously this change is good, are there any lessons from the discussion in #127 that we want to incorporate in this PR? cc @kevinzakka

yuvaltassa avatar Mar 06 '24 11:03 yuvaltassa

Great, thanks for the pointer @yuvaltassa Agree, I updated ffmpeg's arguments to work well with the humanoid example.

There is always a black rectangle on the bottom left which should be the "subsampled depth image" https://github.com/google-deepmind/mujoco/blob/a00f1b5f3043ed1cf676b130a15a2b2ee7700db3/sample/record.cc#L278 image

I would push one more change to optionally disable the depth map overlay through a command line arg, e.g.: record humanoid.xml 5 60 rgb.out 0

jmargeta avatar Mar 06 '24 14:03 jmargeta

With pleasure! I think it is a much better PR than it originally was and I got to learn something new about offscreen rendering as a bonus, so thank you @yuvaltassa =)

jmargeta avatar Mar 07 '24 12:03 jmargeta