lab2d icon indicating copy to clipboard operation
lab2d copied to clipboard

Refactor precommit to use actions/setup-python.

Open jagapiou opened this issue 3 years ago • 3 comments

jagapiou avatar Mar 25 '22 19:03 jagapiou

If we build wheels with macos-11, will that make the wheels less compatible? Or are we expecting most users to be recent enough?

tkoeppe avatar Mar 26 '22 00:03 tkoeppe

I was thinking that we'd increase compatibility by building with both 11 and 10.15. But actually I've just checked and 11 can build from 10.15 wheels. I'll revert the last commit.

jagapiou avatar Mar 26 '22 12:03 jagapiou

I was thinking that we'd increase compatibility by building with both 11 and 10.15. But actually I've just checked and 11 can build from 10.15 wheels. I'll revert the last commit.

The opposite would seem to be the case: the more recent your build environment, the more stringent your requirements, since you require users to be "at least as recent" as your build environment.

Yes, retaining the older env for building would seem to be better, not worse.

The only case you could make is for Py 3.10 support, I suppose. But maybe let's cross that bridge when there's active demand. (And we probably need to figure out a way to support M1 before we support Py 3.10.)

tkoeppe avatar Mar 26 '22 22:03 tkoeppe

I've updated the precommit to use macos-12 and macos-13, and make wheels for pythons 3.8-3.11, and I'm not sure there's much else we need to do at the moment.

What I did notice for macOS was that there's no macOS equivalent of Linux's "manylinux" configuration, so we don't have a single, universal macOS wheel. I've heard people specify compiler flags to build binaries compatible with 10.15 and newer, which is perhaps something we could entertain. I'm not sure what the downsides are compared to building for each platform separately.

But in any case I'm going to close this. Please feel free to reopen if there is new information.

tkoeppe avatar Jun 06 '23 19:06 tkoeppe