Fix HanabiState.copy setting a bad pointer for _game member
Fixes HanabiState.fireworks() returning incorrect data when called on a copied HanabiState object.
Came across this bug in work-related project.
The bug is pretty easily fixed by retrieving the parent game of the state into an existing pyhanabi_game_t* instead of returning a void pointer as was done before.
Steps to reproduce the bug as it existed:
- Create a
HanabiStateobject by callingHanabiState.copyor using the copy constructor manually -
HanabiState._gamewill receive ahanabi_learning_env::HanabiGame*rather thanpyhanabi_game_t*. -
HanabiState.fireworks()and any derivedHanabiObservation.fireworks()calls will return bad data, becauselib.NumPlayers/lib.NumColors/lib.NumRankswill access garbage memory when called on the resulting_gamefield.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
Hi 98devin, Thank you for the suggested fix. It looks right to me. Could you please sign the CLA, and I'll merge those changes?