bsuite icon indicating copy to clipboard operation
bsuite copied to clipboard

MDP Playground integration into bsuite

Open RaghuSpaceRajan opened this issue 3 years ago • 5 comments

Hi @iosband and @yotam,

Hope you're doing well!

Following our discussions, I added MDP Playground experiments into bsuite for the following dimensions of MDP Playground: Delay, Transition Noise, Reward Noise, Reward Sparsity, Rewardable Sequence Length

Here is a short summary of the changes we have made:

  • Added MDP Playground environments and experiments into bsuite Updated analysis Jupyter notebook:

    • Added a spoke in the bsuite spider plot for MDP Playground environments.
    • Added additional analyses cells for individual MDP Playground experiments:
      • Delay, Transition Noise, Reward Noise, Reward Sparsity, Rewardable Sequence Length
  • Added a guide on how to add new experiments into bsuite to CONTRIBUTING.md

  • Updated setup.py to include mdp-playground as a dependency

  • Changed HPs for A2C because performance was very noisy with the old ones

  • Removed Jupyter notebook conflicts with deepmind:master

  • Removed .gitignore conflicts with deepmind:master

Improvements still needed:

  • The code still needs to conform to the Python style that bsuite follows.
  • The tests probably need some improvement.

Please let us know your inputs and feedback on what to do next!

Best regards, Raghu Rajan.

Co-authored-by: suresh-guttikonda [email protected] Co-authored-by: guttikon [email protected]

RaghuSpaceRajan avatar Mar 30 '21 21:03 RaghuSpaceRajan

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 30 '21 21:03 google-cla[bot]

@googlebot I fixed it.

sguttikon avatar Mar 31 '21 11:03 sguttikon

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 31 '21 11:03 google-cla[bot]

@googlebot I fixed it.

sguttikon avatar Mar 31 '21 11:03 sguttikon

Hi @iosband and @yotam,

Could you please restart the workflow tests? I managed to fix the failing pytype tests in the latest commit and pytest tests are also passing locally.

RaghuSpaceRajan avatar Apr 28 '21 15:04 RaghuSpaceRajan