acme icon indicating copy to clipboard operation
acme copied to clipboard

Release `wrappers` as PyPI package

Open kevinzakka opened this issue 2 years ago • 4 comments

Would it be possible to release the wrappers module as a separate PyPI package, similar to how dm_robotics has released the submodules as separate packages? The wrappers are pretty useful (I believe they are the only dm_env wrappers I've seen that don't involve converting to a Gym env) but I don't want to install the entire acme package and its dependencies given that it's not installable on macOS.

kevinzakka avatar May 16 '22 18:05 kevinzakka

I think it may be possible to refactor the core_dependencies https://github.com/deepmind/acme/blob/master/setup.py#L49 in the setup.py to include the minimal, allowing you to install acme as a standalone package where you can just use the wrappers. I think currently the only dependency that is unnecessary in this case would be launchpad. I believe the places where this is used outside the agents are in the environment loops and some utilities.

ethanluoyc avatar May 17 '22 13:05 ethanluoyc

@ethanluoyc That's definitely an option. Was also wishfully hoping for a dm_wrappers separate codebase, a la dm_env.

kevinzakka avatar May 17 '22 16:05 kevinzakka

Another possible direction would be to make dm_env provide those wrappers and Acme could use it.

qstanczyk avatar May 23 '22 12:05 qstanczyk

@qstanczyk can you work some magic internally 😉?

kevinzakka avatar May 23 '22 13:05 kevinzakka

Is it done or not planned?

wookayin avatar Oct 16 '23 20:10 wookayin

@wookayin Made my own.

kevinzakka avatar Oct 16 '23 20:10 kevinzakka