sceneform-android-sdk icon indicating copy to clipboard operation
sceneform-android-sdk copied to clipboard

Migrate to androidx

Open anacoimbrag opened this issue 4 years ago • 6 comments

Since this project now is opensouce (thanks for it), I had lot of issues placing it in my project with androidx. I've done the migration in my fork, is the project accepting pull requests for this?

anacoimbrag avatar Mar 27 '20 15:03 anacoimbrag

Hi Ana:

Have you done a comprehensive battery of tests with your migration to AndroidX? Is it production-level stable at the moment?

Best regards.

vortice3D avatar Apr 15 '20 18:04 vortice3D

@vortice3D Anecdotally I use @anacoimbrag fork and have had no problems since I started using it (several weeks ago now) -- but of course looking forward to both of

  • official androidX-ification
  • restoration of maven functionality

tellypresence avatar Apr 19 '20 23:04 tellypresence

Thanks for the feedback @tellypresence.

I'm also using it at the moment without problems except for the 1.16.0 version issues.

Best regards.

vortice3D avatar Apr 20 '20 06:04 vortice3D

Hi @vortice3D I haven't tested enough to be sure it's production ready, but I didn't know you were accepting PRs. I can do this and get back here 😊

anacoimbrag avatar Apr 25 '20 17:04 anacoimbrag

Hi @anacoimbrag.

Well, we were in a hurry with a production development app where we needed to use AndroidX, and so your PR was very convenient indeed.

For your information, it has been tested in a very intensive way with not special issues (apart from the usual 1.1.6.0 ones) so for us is completely OK for production.

Said that, the release of the next SDK version must be on its way down (maybe a major upgrade coinciding with the Google IO), and we suppose they are adding AndroidX support among a lot of other things that 1.16.0 version didn't implement in a very polished way.

Best regards.

vortice3D avatar Apr 27 '20 06:04 vortice3D

@vortice3D thanks for the feedback! I'm very happy to hear it.

But I really hope they are working on new releases, especially because there's not going to be Google IO this year (https://events.google.com/io/).

anacoimbrag avatar May 07 '20 12:05 anacoimbrag