mediapipe icon indicating copy to clipboard operation
mediapipe copied to clipboard

Holistic with refine_face_landmarks

Open liuyulvv opened this issue 1 year ago • 1 comments

Please make sure that this is a bug and also refer to the troubleshooting, FAQ documentation before raising any issues.

System information (Please provide as much relevant information as possible)

  • Have I written custom code (as opposed to using a stock example script provided in MediaPipe): No
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04, Android 11, iOS 14.4): Windows10
  • Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
  • Browser and version (e.g. Google Chrome, Safari) if the issue happens on browser:
  • Programming Language and version ( e.g. C++, Python, Java): C++
  • MediaPipe version: 0.8.10.2
  • Bazel version (if compiling from source): 5.2.0
  • Solution ( e.g. FaceMesh, Pose, Holistic ): Holistic
  • Android Studio, NDK, SDK versions (if issue is related to building in Android environment):
  • Xcode & Tulsi version (if issue is related to building for iOS):

Describe the current behavior:

To enable refine_face_landmarks in Holistic, I add the code below after FlowLimiterCalculator:

node {
    calculator: "ConstantSidePacketCalculator"
        output_side_packet: "PACKET:refine_face_landmarks"
        node_options: {
        [type.googleapis.com/mediapipe.ConstantSidePacketCalculatorOptions]: {
            packet { bool_value: true }
        }
    }
}

And add input_side_packet: "REFINE_FACE_LANDMARKS:refine_face_landmarks" in node HolisticLandmarkCpu.

But the iris is not marked in the output.

Describe the expected behavior:

Left and right iris should be marked.

Fix:

Add left and right iris connections in holistic_tracking_to_render_data.pbtxt

I add connections from face_mesh_connections.

C++'s face_mesh_connection and python's seem to be the opposite of left and right

Standalone code to reproduce the issue: Provide a reproducible test case that is the bare minimum necessary to replicate the problem. If possible, please share a link to Colab/repo link /any notebook:

Other info / Complete Logs : Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached

liuyulvv avatar Aug 06 '22 00:08 liuyulvv

Hi @liuyulvv, Have you looked at this closed issue #1546 and comment to combine Holistic with iris detection. Thank you!

kuaashish avatar Aug 09 '22 08:08 kuaashish

Are you satisfied with the resolution of your issue? Yes No

google-ml-butler[bot] avatar Aug 13 '22 10:08 google-ml-butler[bot]