capybara-select2 icon indicating copy to clipboard operation
capybara-select2 copied to clipboard

Published 20 hours ago • verified publisher icon goodwill

Fix timeout and backward compatibility issues

Open Hirurg103 opened this issue 8 years ago • 5 comments

Hirurg103 avatar Oct 05 '16 22:10 Hirurg103

@divineforest could you please review this work. Thanks

Hirurg103 avatar Oct 06 '16 10:10 Hirurg103

@goodwill what do you think about these changes?

Hirurg103 avatar Nov 24 '16 13:11 Hirurg103

Guys, is somebody responsible for this project?

Hirurg103 avatar Sep 22 '17 08:09 Hirurg103

I also encountered slow selects - those users who run an older version of select2 will be affected, those who run the current version (4.0?) will not be.

The patch in this PR was intermittently failing at the finds for me, hence I adopted a slightly different approach. I cut out all select2 4.0 code and just left the old-version code (https://github.com/p-salido/capybara-select2/commit/4cdb9684cbefd064406cafba54634fadb1f9cd57).

This was passing in chrome but failing in poltergeist, due to what seemed like select2 being clicked before it was actually a select2 control. Hence I added https://github.com/p-salido/capybara-select2/commit/ed02fcf37ae95d4a308f78049f4c4d8c71777363 to retry the click and delay the first click a bit and this so far seems to be working on both chrome and poltergeist.

p-salido avatar Dec 20 '17 15:12 p-salido

@p-salido I released a rework of this gem and tried to fix all the compatibility and performance issues

Hirurg103 avatar Sep 13 '18 19:09 Hirurg103