Han Wang

Results 63 comments of Han Wang

@vspinu have you verified whether the new package resolves the conflicts?

That is not the (only) issue. The biggest problem, if you look at the result, it selects index 2 as the first choice. If you set k to 1, you...

I understand, but it seems l2 works just fine. And also this example has only 4 records and I think the second and third records are different enough. I am...

Got it, yes we can take a look. We also plan to remove antlr from our core dependency starting from Fugue 0.9.0, but that will take a while.

Actually I don't know why it matters. Fugue has very good support of pyspark, we have never seen such a conflict.

Ah I see, but requirements is not a part of the pypi package, the requirement should have nothing to do with it. But let me investigate. This is very weird.

@vspinu I have found the issue and here is the PR to fix this problem. https://github.com/fugue-project/fugue-sql-antlr/pull/22 Sorry it took a bit long. 0.1.8 should be ready tomorrow