Dmitry Bondarenko

Results 23 comments of Dmitry Bondarenko

Are there any plans for including this feature (like a planned target release for the first draft)?

Hmm, I'll try this approach!

Hey @boonsanti Thank you for your request! Can you please add/run some unit tests for this in the https://github.com/goodsign/monday/blob/master/monday_test.go file?

Hey @mikejamesli Thank you for finding this, I'm unavailable at the moment, unfortunately, but I should be able to find time to accept a PR, so can someone please check...

Hey @yusufozturk Thanks for the contribution! Won't you want the `detectLocale` method become public instead? I'm a bit hesitant to make an internal thing such as `lastLocale` as public, because...

@yusufozturk I see your point, but in this case I feel like we'd introduce some hacky API honestly, as the `lastLocale` shouldn't be a part of the struct in future....

The `Parse` in this case could be transformed into something like: ``` func (ld *LocaleDetector) Parse(layout, value string) (time.Time, error) { locale, err := ld. DetectLocale(layout, value) if err !=...

I'd use some help with the PR/tests, actually 😆 As I'm not able at the moment, but I can review a PR with the approach above.

Hey guys, I'm definitely not an expert in Swedish, these translations were from PRs, so I can't validate them properly. But please PR with a correction if something is not...

I practically was able to build a [test "CLI" version of the generator](https://github.com/goodsign/vscode-flutter-i18n-json/blob/develop/src/cli-generator.ts) very easily by just replacing all the `ua.prompt` calls to explicit function parameters. And it worked out...