tractor icon indicating copy to clipboard operation
tractor copied to clipboard

Make `maybe_open_context()` re-entrant safe, use per factory locks

Open goodboy opened this issue 3 years ago • 1 comments
trafficstars

As discovered and discussed in code review of https://github.com/pikers/piker/pull/331 during refactoring we can't currently support re-entrant usage of tractor.trionics.maybe_open_context().

This fixes that by using a per-target id(acm) lock table to avoid deadlock on the previous single global lock design.


TODO:

  • [ ] tests..

goodboy avatar Aug 24 '22 16:08 goodboy

Lol what's with windows CI all of sudden?

goodboy avatar Aug 24 '22 19:08 goodboy