angular-librarian icon indicating copy to clipboard operation
angular-librarian copied to clipboard

Adding protractor configuration

Open el-davo opened this issue 7 years ago • 3 comments

Following discussion on - https://github.com/gonzofish/angular-librarian/issues/56 here is the pr. Let me know what you think?

el-davo avatar Jul 18 '17 18:07 el-davo

I'm going to take a look at this tonight.

After an initial look, I think we might need to make the approach more general for scaffolding, but since I don't really know Protractor or its best practices, I may be wrong.

gonzofish avatar Jul 19 '17 14:07 gonzofish

Thanks for the awesome feedback. Again please feel free to decline this pr if you feel it can be improved. I will gladly give it another stab at a future date. I wish i had more time to commit to this 🥇

el-davo avatar Jul 19 '17 19:07 el-davo

Thanks for contributing. It's really nice to have people commit time to something you've done. I think the changes are pretty light, so do them when you have a shot, no rush.

gonzofish avatar Jul 19 '17 22:07 gonzofish