Pedro Gonnet

Results 11 comments of Pedro Gonnet

Hi Manodeep, Thanks for your feedback! The macros in `vector.h` were originally written for SSE2 and subsequently extended for AVX/AVX2/AVX512/AltiVec, mostly via copy-paste, so any inexistant intrinsics would only ever...

Hi @Maratyszcza, Please let me know if you have the time to review this PR or not, or whether you are still accepting PRs or not :relaxed: Cheers, Pedro

What's also missing is a unit test for the `xnn_popcnt_s32` intrinsic itself in `XNNPACK/test/s32-simd.cc.in`.

Hi Loic! Yes, it's been a while :) And happy to hear there's continuing interest in CSDS! My only concern regarding migrating the repository is whether/how `swiftsim` will link to...

I think you will also need to update the `CMakeLists.txt` files in the `bench/` and `test/` subdirectories as well.

Hi @Sentimentron, I think most of our users use `cmake` for Android builds, and this path is also covered in our GitHub workflows. You likely need to set up the...

Hi @AvilaGTZ , The function `xnn_define_exp` is defined in [`src/subgraph/deprecated.c``](https://github.com/google/XNNPACK/blob/ea1906f8df2faf8172da1b341c563bf9115581dd/src/subgraph/deprecated.c#L261-L265). Are you sure this is being linked in whith your build target? Cheers, Pedro

Hi, Could you print a stack trace at the start of your kernel (or run in a debugger and set a breakpoint there) to see how your kernel is being...

What is the purpose of removing the granular targets in `src/configs/BUILD`? I'm asking because I only recently split these out because it's best practices to have as granular targets as...

@mcr229 I'm still confused about the intent of this change. If you need the list of config files, it's just the source files in `XNNPACK/src/configs/`. The granular targets were part...