Gary O'Neall

Results 1059 comments of Gary O'Neall

Version 2.0.0 is now released.

@simcha-vos-from-tu-delft Thanks for adding the report - I'm always looking for feedback to improve the quality of the libraries I maintain. In addition to the static code analysis and testing...

@lumjjb @nishakm - Can you take a look at this one?

Discussed on the tech call 10 Dec 2024 - Agreed we won't need to update the actual SHACL constraints. Should be fine as is. May want to clarify the description....

@rfscholte - can you provide a bit more specifics on a recommended approach? We would like to continue to support Java 8 which doesn't support modules, at the same time...

Thanks @rfscholte @bact - I'll work on a PR based on the suggestions

From reading [this article](http://branchandbound.net/blog/java/2017/12/automatic-module-name/), it looks like adding the `Automatic-Module-Name` entry in pom.xml will add it to the Manifest and not impact the ability to use the library in Java...

@bact @rfscholte - Please review the following PR's: - https://github.com/spdx/spdx-java-core/pull/30 - https://github.com/spdx/spdx-java-model-2_X/pull/16 - https://github.com/spdx/spdx-model-to-java/pull/15 This now generates the following dependencies: ``` [INFO] The following files have been resolved: [INFO] org.slf4j:slf4j-api:jar:2.0.7:compile...

> Please review the module name addition in org.spdx.v3jsonldstore > > * [Add Automatic-Module-Name and more Javadoc description spdx-java-v3jsonld-store#17](https://github.com/spdx/spdx-java-v3jsonld-store/pull/17) Done. I only looked at the dependencies on the Java library....

I believe this is now resolved for the SPDX java library - I'll go ahead and close this issue. @rfscholte - if I missed anything we can re-open or open...