php-pushwoosh icon indicating copy to clipboard operation
php-pushwoosh copied to clipboard

Possibility to filter notification target(s) by user(s)

Open Xplouder opened this issue 8 years ago • 6 comments

Let me know if the tests are mandatory or just optional.

Xplouder avatar Jul 17 '17 13:07 Xplouder

Coverage Status

Coverage decreased (-0.3%) to 99.581% when pulling 0a49b715de20422e2274db5765474e25f606051c on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls avatar Jul 17 '17 14:07 coveralls

Hi @Xplouder and thanks for this new feature.

Let me know if the tests are mandatory or just optional.

Yes, since version 1.8.0 code coverage is 100%, to respect our quality standards we wish to keep 100% code coverage now.

So could you complete the unit tests associated to the Notification class to increase the code coverage ?

Thanks

bgaillard avatar Jul 21 '17 11:07 bgaillard

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls avatar Jul 24 '17 09:07 coveralls

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls avatar Jul 24 '17 09:07 coveralls

Coverage Status

Coverage increased (+0.0006%) to 99.832% when pulling c96b3efdfcc515c7cd8f163f5b5484ea6de7258e on Xplouder:feature/filter_by_users into 89d609e6f824ad2becaf2df9d65a8fb07a413cec on gomoob:master.

coveralls avatar Jul 24 '17 09:07 coveralls

@bgaillard Any ETA to get this merged?

Xplouder avatar Aug 03 '17 11:08 Xplouder