it icon indicating copy to clipboard operation
it copied to clipboard

Mappable vs Mapable

Open wkhere opened this issue 1 year ago • 1 comments

Hi!

Your API has Mapable while it's spelled Mappable in your readme, so there seems to be confusion about the proper form. English is not my native language so I am not sure, Mappable looks more correct. Plus this: https://en.wiktionary.org/wiki/mapability "misspelling of mappability".

Do you think it's ok to have yet another API change?

wkhere avatar Oct 10 '24 20:10 wkhere

Hi,

it's not mine mother tongue as well :-). It looks like the variant with double p is the correct: https://en.wiktionary.org/wiki/mappable

As there are no other packages using it according pkg.go.dev and no v1 has been released, feel free to sent a PR.

Thanks for looking at this.

vyskocilm avatar Oct 10 '24 20:10 vyskocilm

Ah yeah, sorry for not closing this issue right away after PR was merged :) all good

wkhere avatar Oct 22 '24 13:10 wkhere