athens icon indicating copy to clipboard operation
athens copied to clipboard

Error message not clear

Open hydezhao opened this issue 1 year ago • 2 comments

Describe the bug A clear and concise description of what the bug is.

When configuring the proxy ( version 0.13.1) with :

            downloadURL =  "https://proxy.golang.org"
            mode =  "redirect"

I got lots of error messages in log like:

ERROR[2:39PM]: redirect	http-method=GET http-path=/gopkg.in/gorp.v1/@v/v1.7.2.zip request-id=613a7b67-3b2f-4814-a293-73bd370c4088
INFO[2:39PM]: incoming request	http-method=GET http-path=/gopkg.in/gorp.v1/@v/v1.7.2.zip http-status=301 request-id=613a7b67-3b2f-4814-a293-73bd370c4088

while in logs of go download i see:

# get https://athens.example.com/gopkg.in/gorp.v1/@v/v1.7.2.mod: 200 OK (0.062s)

meaning it successfully downloaded the package.

So, what does the ERROR message mean in log ?

To Reproduce Steps to reproduce the behavior:

Expected behavior A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • OS: [e.g. Linux 64bit] Linux
  • Go version :
  • Proxy version : 0.13.1
  • Storage (fs/mongodb/s3 etc.) : s3

Additional context Add any other context about the problem here.

hydezhao avatar Jan 12 '24 14:01 hydezhao

From what I can determine this is standard when you set mode to redirect.

It looks like if the target zipped archive is not present on the system then it redirects the caller to the URL of where the archive can be found without storing it.

@hydezhao is your point that it shouldn't be an error and is better described as intended functionality?

matt0x6F avatar Jan 28 '24 19:01 matt0x6F

Hello @matt0x6F yes exactly. If there is no "error" we shouldn't tag the log with ERROR, which spams the log and creates confusion .

hydezhao avatar Jan 31 '24 16:01 hydezhao