athens icon indicating copy to clipboard operation
athens copied to clipboard

[helm chart] secrets keys should be set in a secret, not as clear text env in deployment

Open draeron opened this issue 5 years ago • 2 comments

All secret keys (for aws, minio etc) should be in a external k8s secret instead of directly be as env variable.

https://github.com/gomods/athens/blob/main/charts/athens-proxy/templates/deployment.yaml#L103

draeron avatar Sep 15 '20 16:09 draeron

@draeron are you wanting to create a secret outside of the helm chart, and then bring it into your pod as an environment variable?

arschles avatar Nov 20 '20 19:11 arschles

By external i meant the chart itself should create the secrets and the deployment should refer to it via a secretKeyRef.

draeron avatar Nov 20 '20 22:11 draeron