nestjs icon indicating copy to clipboard operation
nestjs copied to clipboard

feat: add wildcard topic matcher, support * and # in routingKeys

Open Dryymoon opened this issue 1 year ago • 3 comments

Thanks for a good library!

This fix add:

  • Support for amq.topic willcard routing key matching using '@artie-owlet/amqp-routing-match' lib

For example: message with routing key service.v1.log should match routing key service.v1.* and service.#

  • Fixed silently message looping when getting message with mismatching with defined routing key.

  • Fixed package.json mismatch

Dryymoon avatar Dec 10 '23 00:12 Dryymoon

@Dryymoon Could you rebase?

underfisk avatar Jan 14 '24 23:01 underfisk

@ttshivers If you have some free time and could help the buddy out, i can probably get this merged soon. I wish there was some test coverage as I've never used this library before, have you ever used it? Are there any cons of getting it merged using this library?

underfisk avatar Jan 16 '24 17:01 underfisk

@ttshivers If you have some free time and could help the buddy out, i can probably get this merged soon. I wish there was some test coverage as I've never used this library before, have you ever used it? Are there any cons of getting it merged using this library?

I'm trying to understand the goal of this PR. Is this to double check that the message received on a queue matches the routing keys defined in code? Is the thought that there might be extra queue bindings defined on rabbitmq and we should do consumer verification and throw errors when we get unexpected messages?

ttshivers avatar Jan 16 '24 18:01 ttshivers

I'm closing this PR, we'll re-open if we figure out that it is actually valuable. @ttshivers has left some interesting thoughts, i'd love to also understand a bit better this change

underfisk avatar Feb 29 '24 23:02 underfisk