yapapi icon indicating copy to clipboard operation
yapapi copied to clipboard

AgreementsPool.on_agreement_terminated is never called

Open johny-b opened this issue 2 years ago • 1 comments

There's a method:

    async def on_agreement_terminated(self, agr_id: str, reason: dict) -> None:
        """Reacts to agreement termination event

        Should be called when AgreementTerminated event is received.
        """
        ...

that does some things, but is not called from anywhere. It should either be removed, or used (it says it "should be called", but it's hard to trust the docstring of an abandoned method;p).

johny-b avatar Mar 14 '22 13:03 johny-b

rather than removing it, I'd have it called when it should

shadeofblue avatar Mar 14 '22 16:03 shadeofblue